Skip to content

fix: address small findings from the type checker review 🧹 - #319

Merged
timfennis merged 1 commit into
feat/type-checkerfrom
fix/review-small-fixes
Nov 13, 2026
Merged

timfennis merged 1 commit into
feat/type-checkerfrom
fix/review-small-fixes

Conversation

@timfennis

Copy link
Copy Markdown
Owner

Small fixes from the review of the type checker (#291):

  • zip takes any sequence, as its Iterable signature says. It used to accept only lists and tuples, so zip("ab", "cd") or zip over a range passed analysis and failed at runtime. It now steps the arguments' iterators together and stops at the shortest, so an endless range works as one of them.
  • The compiler no longer copies an instance's pick tables for each instance it compiles. It refers to the instance by its declaration and index in Analysis::instances.
  • The manual's number page says that a later use can make a let-bound literal a Float, which changes what / and \ do.
  • declared_symbol's doc comment is back on declared_symbol; it had ended up on declare_instance.

🤖 Generated with Claude Code

https://claude.ai/code/session_015rQP9SKVmpvME4F2LXeWmG

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T10:08:05.018676Z cd60536 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@timfennis
timfennis merged commit 49cfc7c into feat/type-checker Nov 13, 2026
1 check passed
@timfennis
timfennis deleted the fix/review-small-fixes branch November 13, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant