Repository navigation
fix(analyser): report a generic function whose type grows too large 📏 - #334
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each generic function's type can be twice the size of the type of the one it calls, so a chain of them grows exponentially, the known worst case of Hindley–Milner inference. With
fn f0(x) => (x, x)andfn fi(x) => f{i-1}(f{i-1}(x)), analysis ran out of memory atf6, even with the call behindif false.A generic function whose type has more than 10,000 parts is now reported ("The type of
f4has more than 10000 parts, too many to work with", with help to annotate a parameter or the return type withAny), like rustc's type length limit, and is analysed from there on as taking and returningAny, so the functions that call it don't grow it further. The size is counted once per generic function, stopping at the limit.🤖 Generated with Claude Code