Repository navigation
fix(analyser): give a while true loop no break leaves no value 🔁 - #337
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
whileloop always had the unit type, evenwhile truewith nobreak, which only ends by returning. A function whose body ends in one therefore returned the join of itsreturns and(), which isAny, and everything computed from its result wasAnytoo. Found in an Advent of Code solution:fn merge_ranges(ranges) { … while true { … if done { return rc; } … } }maderrAny, so[(hi - lo + 1) for (lo, hi) in rr].sumfailed to find asumforList<Any>.A
while trueloop that nobreakleaves now has typeNever, like areturnor Rust'sloopwithout abreak, so a function ending in one returns what itsreturns do. Abreakinside a nested loop leaves that loop, not this one. To tell, the analyser's loop depth became a stack of loops that records whether abreakleaves each.The manual's while-loop page describes it.
🤖 Generated with Claude Code