Repository navigation
feat(stdlib): add panic, and type combinations, permutations and find_subsequence 📐 - #346
Merged
Merged
Conversation
…_subsequence 📐 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for making
Anyexplicit (#331): these built-ins gaveAnythat nobody wrote, which would need a cast at every use onceAnyonly comes out throughas.panic(message)stops the program with the message and has typeNever, so it can end a branch whose other branches give a value:if c { 1 } else { panic("no such thing") }is anInt.assert(false)can't do this, asassertreturns when its condition holds.combinations(xs, k)andpermutations(xs, k)now give lists rather than tuples, askis only known when the program runs:Iterator<List<T>>andList<List<T>>instead ofAny. Destructuring them works as before; they print as[1,2]rather than(1,2). On the advent-of-brian day 8 solution, nothing in the pair loop is picked as the program runs any more, which made part 2 about a third faster.find_subsequencereturned the index or(), typedAny. It now returns anIntand fails when the subsequence isn't there, and the newfind_subsequence?returns anOption<Int>, likefirst/first?. An empty subsequence is found at 0 instead of panicking.🤖 Generated with Claude Code