Repository navigation
fix(analyser): don't report errors that follow from an earlier one 🧯 - #348
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326. When a check failed, the analyser gave the failed expression the type
Any, and everything built from it could fail again, so one mistake gave several errors whose help pointed the wrong way:reported the missing
lenand then "No function called 'sum' found that matches the arguments 'List'", with a hint to cast. It now reports only the first. This is also groundwork for makingAnyexplicit (#331), where an error-recoveryAnywould cause even more such errors.StaticType::Error, which fits anything both ways, joins with anything as itself, and iterates and unpacks as itself. It's only used by the analyser: the types it hands to the compiler, VM and LSP turn it intoAny, which is what hover and inlay hints showed before.Any(no overload, a committed overload that didn't fit, tuple index out of bounds, growing recursion, not iterable, a failed unpack, bad annotations, a type that grows too large, names in a statement with name errors) now return it.As with rustc and TypeScript, a call passed a failed value reports nothing about its other arguments either. Errors in a value's declared type are still reported: after
let s: String = missing();,let n: Int = s;is still an error. Every existing test program reports the same errors as before; analysis time is unchanged.🤖 Generated with Claude Code