Repository navigation
refactor(analyser): delete the runtime checks Any values no longer need 🧹 - #356
Merged
timfennis merged 1 commit intoNov 14, 2026
Merged
Conversation
…ed 🧹 With explicit Any, a value of type Any only goes where Any is taken, so the implicit checks the analyser recorded for Any values never fire for a program without errors. Delete the ExpectType opcode, the type_checks tables, the checks the analyser and instances collected for them, the argument nodes calls carried to place them, the string branches of the generic prefixes and suffixes, and the Any relaxations for function values in overload picking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #353 an
Anyvalue only leavesAnythrough a cast, so the checks the analyser added where anAnywas passed or stored never fire in a program that analyses without errors. Part of #331.ExpectTypeopcode, thetype_checkstables, the analyser code that recorded them (expect,expected_of_any, the instance checks), and the argument nodes calls carried only for them.Anyreached: theDynamicarm ofchoose_function_value, theAnyrelaxation for function types inStaticType::matches, and the string branches of the genericprefixes/suffixes.The VM still picks overloads by looking inside containers, for a generic function's own body when it's used as a value (#355).
🤖 Generated with Claude Code