Repository navigation
skip match on bindArg of block-type opcodes - #732
Open
ejrgilbert wants to merge 1 commit into
Open
ejrgilbert wants to merge 1 commit into
ejrgilbert wants to merge 1 commit into
Conversation
titzer
approved these changes
Oct 27, 2026
titzer
left a comment
titzer
left a comment
Owner
There was a problem hiding this comment.
LGTM, but a spectest failure is blocking CI.
Contributor
Author
Yeah, looks like that failure's happening on other PRs. Did spectests change? |
Owner
|
I fixed the spectest failures, but I can't rerun your PR unless the hash changes, which means you need to rebase and push. |
ejrgilbert
force-pushed
the
bugfix/no-match-block-opcodes
branch
from
October 30, 2026 19:50
129ca77 to
85fe51f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When matching block-type opcodes (block/loop/if), we need to skip probe callbacks that don't match the typing information for args/results (functionally similar to what we do for call/call_indirect).