Repository navigation
Don't scan stacks without a mapping; add more GC tests - #739
Merged
Merged
Conversation
NativeStack registered a GC scanner even for stacks without a mapping (e.g. the sample in V3Offsets), whose scan() dereferenced a null range when the stack was live during a GC (seen with -O3). New tests: - regress tests for GC object accesses, allocations, and casts (inline_access0, inline_alloc0, inline_cast0) - 204 generated cast tests for struct hierarchies of up to 5 types, with final types, rec groups, unrelated hierarchies, and abstract types (gen_cast_display.py) - a Wasm GC mode for the Virgil tests (test/virgil/test-gc.sh) - GC microbenchmarks for struct/array reads and writes and subtype casts - unittest accepts engine and compiler options; RttTestVals uses a non-final supertype Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.