Fix: Remove sensitive HTTP payload logging from Ruby SDK clients and templates - #33
Open
magqqgq wants to merge 1 commit into
Open
Fix: Remove sensitive HTTP payload logging from Ruby SDK clients and templates#33magqqgq wants to merge 1 commit into
magqqgq wants to merge 1 commit into
Conversation
…templates ### Description This PR addresses sensitive HTTP payload logging within the `ruby-sdk` repository. **Vulnerabilities & Security Defects Remediated:** * **Sensitive HTTP Payload Logging (`turnkey_client/lib/turnkey_client/api_client.rb`, `turnkey_client_inputs/templates/api_client.mustache`, `turnkey_client_inputs/templates/api.mustache`):** Debug output previously included full request bodies, response bodies, deserialized response data, and response headers. These values could inadvertently expose private keys, signatures, credentials, or other sensitive user data. The API client and its corresponding code-generation templates have been strictly updated to log only non-sensitive transport metadata: the HTTP method, path, operation name, and status code. The templates were updated alongside the client to ensure future regeneration does not reintroduce the defect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses sensitive HTTP payload logging within the
ruby-sdkrepository.Vulnerabilities & Security Defects Remediated:
turnkey_client/lib/turnkey_client/api_client.rb,turnkey_client_inputs/templates/api_client.mustache,turnkey_client_inputs/templates/api.mustache): Debug output previously included full request bodies, response bodies, deserialized response data, and response headers. These values could inadvertently expose private keys, signatures, credentials, or other sensitive user data. The API client and its corresponding code-generation templates have been strictly updated to log only non-sensitive transport metadata: the HTTP method, path, operation name, and status code. The templates were updated alongside the client to ensure future regeneration does not reintroduce the defect.