feat: optional cookies for basicauth - #33
Merged
Merged
Conversation
Lustyn
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds optional configuration for storing basicauth in a cookie, since browsers only store it for session lifetime. there's probably something to be said about the security of this, but i don't think it's really any less than basicauth itself is, or cookies in general. by default the cookies will refresh on half TTL (to avoid set-cookie spam and races), which is why there's an additional timestamp cookie stored. of course the user can tamper with this value, so there's no expectation of serverside enforcement of TTLs here. if the user's cookies are exfiltrated then they have bigger problems. if the sitemaster needs more security, then they should look at other auth solutions imo
configuration: