Skip to content

codex runtime review-trigger loop: not started by a normal launch; its own pr.opened event cannot request a review #644

Open

Description

@tps-flint

The codex runtime's review-trigger loop (cli#631 / PR #642 made it read only the agent's own feed) does not run end to end today:

  • Not started by a normal launch. bin/tps.ts passes autoCommit to runCodexRuntime but not reviewTrigger; the loop starts only when that field is present (utils/codex-runtime.ts).
  • The runtime's own event cannot request a review. Auto-commit publishes pr.opened with a branch name in detail; the review handler needs /pull/<number> and returns normally when it is missing, so the task loop marks the event done and advances its cursor.
  • A failed review request is consumed as handled for the same reason.

Ask:

  • Validate the user's review-trigger config and pass it through the launcher; a real config-file launch starts the loop.
  • Emit pr.opened only after PR creation, carrying the PR URL.
  • Missing PR data or a failed review request fails the handler, so the cursor retries.
  • Tests with configured reviewers asserting the review-request command and payload, for a runtime-produced event and a failed request.

Found in the review of cli#642; pre-existing on main.

Activity

  1. moved this to Triage in Office queueon Oct 14, 2026
  2. self-assigned this
    on Oct 16, 2026
  3. moved this from Triage to In review in Office queueon Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions