promote: board-automation hardening + advance caller to main#77
Merged
Conversation
…ssify cron (#76) Four solo .github hardening items from RFC-BACKEND-0008, all board-automation: - D30 (#1271): /fr-pass must be a real second pair of eyes. Refuse when the commenter is the PR author, and require MEMBER/OWNER (drop COLLABORATOR, which includes read-only outside collaborators). The Functional-reviewer field was set on 0 of 100 items; a self-pass was one comment away. - D27-L4 (#1267a): remove the Release:-title auto-promote. A PR titled 'Release: anything' merged to develop made kanban-reconcile set Status=Prod — rank 10, satisfying every future gate. Deleted; the drift-to-prod path (SHA actually on the prod branch) is the sound mechanism and stays. - D27-L4 (#1267b): resolve the prod branch by probing main/master, not by reading a repo-controlled .kanban.yml from the default branch. A repo could commit 'branch_status_map: {develop: Prod}' and self-grant prod status to every develop merge. Ground truth now comes from the repo's branch list. - D21 (#1279): delete auto-classify.yml. It ran every 10 min to populate Squad (deleted by D4) and rewrite Deploy environment with junk values; it is also what made updatedAt useless as a staleness signal. No callers. actionlint + shellcheck clean; no dangling auto-classify references. Refs tracebloc/backend#1271 #1267 #1279
LukasWodka
added
the
skip-fr-gate
Contributor
Author
|
👋 Heads-up — Code review queue is at 39 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes #76 to
main— the board-automation changes only take effect once callers read them from@main.Carries:
/fr-passrefuses the PR author + requires MEMBER/OWNER (#1271 / D30)Release:-title auto-promote removed; prod-branch resolved by probing main/master not.kanban.yml(#1267 / D27-L4)auto-classify.ymldeleted (#1279 / D21)advance-deploy-env-caller.ymladded — so.github's own promotions advance kanban items (the "stuck at FR on dev" fix)Merge with a merge commit. Gate override (
skip-fr-gate) applies —.githubhas no staging branch (D28).Note
Medium Risk
Changes who can advance kanban via /fr-pass and how items reach Prod; misconfiguration could leave boards stale (no auto-classify) or block legitimate FR sign-offs.
Overview
Removes the scheduled
auto-classifyworkflow that every 10 minutes set Squad/Area from repo mappings and re-synced Deploy environment from Status.Tightens
/fr-pass: only MEMBER or OWNER can trigger it (no COLLABORATOR), and the commenter must not be the issue/PR author so authors cannot self-approve functional review.Hardens nightly
kanban-reconcile: prod branch for “SHA on prod → Prod” drift is resolved by probingmainthenmaster, not repo-controlled.kanban.yml(closes a path to self-grant prod via branch map). Release-vehicle title matching that auto-moved merged PRs to Prod is removed; merged PRs now only promote on merge SHA actually on the resolved prod branch.Reviewed by Cursor Bugbot for commit 99d840d. Bugbot is set up for automated code reviews on this repo. Configure here.