feat(kanban): collapse FR on dev + Ready for staging → On dev (D6, code only)#80
Merged
Conversation
RFC-BACKEND-0008 D6: drop the dev-side functional review. 'FR on dev' and
'Ready for staging' become a single automatic 'On dev'; the one human review
stays at staging ('FR on staging' -> /fr-pass -> 'Ready for prod'). 11 columns
-> 10.
Workflow changes (code only — the live board cutover is a separate deliberate
step, see PR body):
- advance-deploy-env: develop push -> On dev (was FR on dev)
- closure-router: merged-to-develop -> On dev
- fr-pass-comment: drop the FR-on-dev -> Ready-for-staging transition; /fr-pass
now applies only at FR on staging
- fr-gate: staging hop requires 'On dev' (automatic, no human gate); rank table
collapses FR-on-dev(6)+Ready-for-staging(7) -> On dev(6), shifting the rest
- kanban-reconcile: column arrays updated
These reference the 'On dev' option, which must exist before they run live —
hence the cutover sequencing in the PR body. Do NOT merge+promote without the
coordinated option rename.
actionlint clean.
Contributor
Author
|
bugbot run |
Contributor
Author
|
👋 Heads-up — Code review queue is at 39 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0029c27. Configure here.
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC-BACKEND-0008 D6 — collapse
FR on dev+Ready for stagingintoOn devDrops the dev-side functional review. Merge to dev → automatic
On dev(no manual gate). The one human review stays at staging:FR on staging→/fr-pass→Ready for prod. 11 columns → 10.Code changes (this PR — safe, no live-board impact)
advance-deploy-envOn dev(wasFR on dev)kanban-closure-routerOn devfr-pass-commentFR on dev → Ready for stagingtransition;/fr-passnow only atFR on stagingfr-gateOn dev(automatic — no dev-side human gate); rank table collapsesFR on dev(6)+Ready for staging(7) →On dev(6)kanban-reconcileactionlint clean on all five.
These workflows reference the
On devoption, which doesn't exist yet. If they reachmainbefore the option is renamed, every develop-merge fails (On devnot found). Conversely, renaming first breaks the old workflows still onmain. So the cutover must be near-simultaneous, done in a quiet window:developand promote tomain(callers read@main).FR on dev→On devvia the API (preserves the option ID and every item's assignment — this is a rename, not a new option).Ready for staging→On dev.Ready for stagingoption.Steps 1–2 must not be separated by a working day. I'll drive this with you watching, when you're ready — it's the one board-wide change that can strand promotions if mis-sequenced.
Depends on
#1274 (staging in every repo) should land first — a repo with no
stagingbranch still can't complete the ladder. This PR is the column model; #1274 is the branches it flows through.Note
High Risk
Changes org-wide promotion gates and status resolution for every repo using these workflows; deploying before the board option is renamed to
On devwill break develop deploy automation and can block staging merges.Overview
Implements RFC D6 by replacing
FR on devandReady for stagingwith a single automaticOn devcolumn across the reusable kanban workflows (11 → 10 stages in code).Develop path:
advance-deploy-envandkanban-closure-routersetOn devon develop merges (and matching issue mirrors) instead ofFR on dev..kanban.ymloverrides recognizeOn devrather than the old dev FR column.Human FR only on staging:
fr-pass-commentno longer advances fromFR on dev;/fr-passonly movesFR on staging→Ready for prod.Promotion gates:
fr-gaterequiresOn dev(notReady for staging) for PRs targeting staging, and therank()ordering collapses the two removed columns soOn devis stage 6 and downstream ranks shift up by one.Reconcile:
kanban-reconcilescans and treatsOn devin place of the old dev/ready-for-staging columns for drift and misplaced open issues.Cutover note: workflows assume a live Project Status option named
On dev; board rename/migration must happen in the same window as promoting these workflows tomain, or status updates will fail to resolve options.Reviewed by Cursor Bugbot for commit 0029c27. Bugbot is set up for automated code reviews on this repo. Configure here.