fix: Bugbot findings from promotion PR #397 (TLS floor + delete cache)#404
Merged
Conversation
… cache) - installer: pin the TLS 1.2 floor (--tlsv1.2) on the shared installerRunScript download, matching scripts/install.sh, so `tracebloc upgrade` and `prepare-host` can never negotiate a weaker protocol - update-check: skip the post-command nudge after `tracebloc delete` (reuse SkipUpdateNudge) AND make writeUpdateCache refuse to recreate a missing ~/.tracebloc, so a clean offboard is never resurrected by the throttle cache Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5023869. Configure here.
…404) isDeleteCommand matched any leaf named "delete", so the nudge was wrongly skipped after `data delete` too (which neither offboards nor wipes ~/.tracebloc). Replace the name-based upgrade/delete predicates with a self-declared cobra annotation (skipUpdateNudgeAnnotation) set on the top-level upgrade and delete commands, so `data delete` is unaffected. Add a table-guard test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aptracebloc
approved these changes
Jul 24, 2026
Contributor
Functional review \u2014 passed\n\nBasis: the behavioural suites that ran on this PR at merge against real environments, not mocks:\n\n- + \u2014 the CLI exercised against a real kind cluster, plus the installer suite\n\nI could not reach the dev API (no dev credentials), so rather than rubber-stamp I used the strongest evidence available: these suites exercise the actual behaviour this change alters, on real infrastructure. Advancing \u2192 .\n\nIf the functional reviewer wants a manual pass on dev in addition, please move it back and say so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves the second round of Cursor Bugbot findings surfaced on the cli promotion PR (#397, develop → main), both introduced/adjacent to the earlier upgrade fix (#402).
Fixes:
installerRunScript(used bytracebloc upgradeandtracebloc prepare-host) now downloads the installer withcurl -fsSL --tlsv1.2, matching the TLS 1.2 floorscripts/install.shenforces on every security-sensitive fetch, so this privileged download can never negotiate a weaker protocol. (Release develop → main #397 (comment))tracebloc deletewipes~/.tracebloc, the post-command update check no longer resurrects it.SkipUpdateNudgenow also suppresses the nudge (and its cache write) afterdelete— reusing the existing skip mechanism — andwriteUpdateCacheno longerMkdirAlls a missing dir (it only writes when the dir already exists), so a throttle cache can never recreate a just-offboarded host data dir. (Release develop → main #397 (comment))Lands on develop; the promotion PR head picks these up on the next sync and Bugbot re-reviews.
🤖 Generated with Claude Code
Note
Low Risk
Targeted CLI hygiene and TLS hardening on installer fetch; behavior change is suppressing update nudge/cache after offboard and skipping cache writes when the data dir is gone.
Overview
Addresses Bugbot findings from the promotion PR around privileged installer downloads and offboard hygiene after
tracebloc delete.Installer download — Shared
installerRunScript(used byupgradeandprepare-host) now passescurl --tlsv1.2, aligned withscripts/install.sh, so those downloads cannot negotiate below TLS 1.2. A test locks this in for both subcommand variants.After offboard —
writeUpdateCacheno longerMkdirAllthe config parent; it only writes when that directory already exists, so a post-command update check cannot resurrect a wiped~/.tracebloc.SkipUpdateNudgemoves from a hard-codedupgradename check to a Cobratracebloc.io/skip-update-nudgeannotation onupgradeand top-leveldeleteonly (notdata delete). Tests cover the missing-dir cache behavior and the annotation vs. name collision.Reviewed by Cursor Bugbot for commit db9c2ab. Bugbot is set up for automated code reviews on this repo. Configure here.