ci(windows): build volrover3 against the cvcpkg python311 (now published) - #42
Merged
Merged
Conversation
python311 is now published for windows (the windows_pycvc binding stack landed), so the stale 'skip python311 on windows' guard is obsolete — install it on every platform. Also pin -DPython3_EXECUTABLE/-DPython3_ROOT_DIR at the cvcpkg prefix's python.exe so find_package(Python3 Development.Embed) uses the hermetic cvcpkg python311 instead of the runner's setup-python 3.12 (which set Python3_ROOT_DIR in the env). Fixes 'volrover3: embedded Python escaped the dependency prefix'.
… [0]
The embedded-python guard did list(GET CMAKE_PREFIX_PATH 0) and required python
to live under that one entry. On Windows the vcpkg toolchain PREPENDS its own
prefix (C:/vcpkg/installed/x64-windows) at index 0, so the check false-failed
('embedded Python escaped the dependency prefix') even though the cvcpkg
python311 was correctly found under a LATER cvc-deps entry. Iterate all
CMAKE_PREFIX_PATH entries and accept if python resolves under any — a system/
registry python is under none, so hermeticity is still enforced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python311 + the full binding stack (pycvc/pycvc-gl/pyside6/shiboken6) are now published for windows. Remove the stale 'skip python311 on windows' guard and pin find_package(Python3) at the cvcpkg prefix's python.exe so volrover3's embedded-python hermeticity check passes on Windows.