recipe(volrover3): bump cvc_revision 2 -> 3, rebuild against the no-singleton cvcgl - #43
Merged
Merged
Conversation
…w cvcgl cvcGL removed its process-wide cvc::gl::context() singleton (each SceneGraph now owns its state publisher under the injected app, on the publisher's own joined thread) and re-levelled its per-frame VolumeNode logging so a host's console is quiet by default. volrover3 already builds with the injected-app SceneGraph ctor, so no source change is needed — this is a rebuild against the fixed cvcgl. The deps are unpinned, so the build picks up the latest cvcgl/libcvc. A re-publish no-ops on the immutable +cvc.2 revision, so the bump is required to advance the app on cvcpkg.org.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild-and-republish of the volrover3 cvcpkg package against the new cvcgl (libcvc SDK), which removes the process-wide
cvc::gl::context()singleton and quiets cvcGL's per-frame logging (libcvc PR #199).No source change. volrover3 already constructs the scene graph with the injected-app ctor (
MainWindow: make_shared<SceneGraph>(*m_app, "volrover3")) and uses none of the removed API — verified across the repo. The recipe deps are unpinned, so the build picks up the latest cvcgl/libcvc automatically.This is purely a
cvc_revisionbump (2 → 3): the publish workflow packs at the recipe's revision, and a re-publish no-ops on the immutable +cvc.2 already on cvcpkg.org, so the bump is required for the app to advance.Sequencing: publish the new cvcgl/libcvc family first (libcvc #199 merged → libcvc
publish-cvcpkg), then run volroverpublish-cvcpkgwithenable_volrover3=trueso volrover3 links the new cvcgl.