Conversation
…deps The publish-cvcpkg volrover3 job hand-maintained a parallel `cvcpkg install libcvc vtk cvcgl yaml-cpp python311` list that kept drifting from what recipes/volrover3 actually declares — cvcgl, yaml-cpp, python311 and (most recently) imgui each had to be chased down and added here by hand after the recipe already listed the real dependency. Replace it with `cvcpkg install-deps recipes/volrover3`, which installs the recipe's build + runtime deps transitively. The recipe is now the single source of truth for what volrover3 links, and imgui rides in automatically via cvcgl (cvcGL's config does find_dependency(imgui CONFIG) now that the overlay is compiled into libcvcGL.a — libcvc#370), so there is no explicit imgui line to forget. Host tools (cmake/ninja) are excluded by default; the system-deps step still provides the top-level VolumeRover2 configure-gate packages (Boost/FFTW/GSL/log4cplus) that are not volrover3's own dependencies.
Owner
Author
|
Superseded by the combined namespace-port PR (includes this install-deps commit + the cvc::gl source port needed for CI to build green). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your question, answered
It does —
recipes/volrover3/recipe.yamldeclarescvcgl,libcvc,vtk,qt6,yaml-cpp,glew,python311,pycvc-gl-cp311,pyside6-cp311,shiboken6-cp311. The problem was that the publish workflow didn't use them — it hand-maintained a parallelcvcpkg install libcvc vtk cvcgl yaml-cpp python311list that kept drifting from the recipe. That drift is exactly howcvcgl,yaml-cpp,python311, and (most recently)imguieach had to be chased down and re-added here by hand.imguispecifically is not a direct volrover3 dependency and shouldn't be listed as one — volrover3 never touches ImGui directly. It's a transitive dep ofcvcgl(cvcGL's config doesfind_dependency(imgui CONFIG)now that the overlay is compiled intolibcvcGL.a, libcvc#370). The only reason it "went missing" is the hardcoded list didn't resolve transitively.Fix
Replace the hardcoded list with
cvcpkg install-deps recipes/volrover3, which installs the recipe's build + runtime deps transitively. The recipe is now the single source of truth;imguirides in viacvcglautomatically. Host tools (cmake/ninja) are excluded by default; the system-deps step still provides the top-level VolumeRover2 configure-gate packages (Boost/FFTW/GSL/log4cplus) that aren't volrover3's own deps.Note on platform coverage
install-depspulls the full runtime closure too (pyside6/shiboken6/pycvc-gl), so a platform where that closure isn't published yet will fail this step rather than publish a volrover3 bundle whose declared runtime deps can't be installed. The matrix iscontinue-on-error+fail-fast: false, so linux (where the closure is published) still builds and publishes independently. Verifying via a dry-run dispatch.