Conversation
…rack controller Swap `from pycvc_gl.camera import ChaseCamera` for `NativeChaseCamera as ChaseCamera` in scripts/examples/grl_snam_austin_drive.py, so this example runs the SAME follow-camera as C++ instead of the parallel pure-Python implementation (the unification from libcvc #381 / #391). Matches the grl-snam demo migration (CVC-Lab/GRL-SNAM#81, CVC-DBG/grl-snam-dbg#82). Pure drop-in: NativeChaseCamera has the identical constructor and update(pos, dt) -> (eye, target, up) contract (the example only calls update), and libcvc's cvcgl_track_parity (C++, 7.1e-15) and test_pycvc_gl_chase_parity (Python) prove it returns the same pose as the pure-Python ChaseCamera. Behaviour is unchanged. NOTE: merge only once a pycvc-gl package that ships NativeChaseCamera (built against a cvcGL with #381's push-feed: feedTrackTarget/get_pose) is installed — the currently-installed pycvc_gl extension predates it. Prepared, not merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap
from pycvc_gl.camera import ChaseCameraforNativeChaseCamera as ChaseCamerain scripts/examples/grl_snam_austin_drive.py, so this example runsthe SAME follow-camera as C++ instead of the parallel pure-Python implementation
(the unification from libcvc #381 / #391). Matches the grl-snam demo migration
(CVC-Lab/GRL-SNAM#81, CVC-DBG/grl-snam-dbg#82).
Pure drop-in: NativeChaseCamera has the identical constructor and
update(pos, dt) -> (eye, target, up) contract (the example only calls update), and
libcvc's cvcgl_track_parity (C++, 7.1e-15) and test_pycvc_gl_chase_parity (Python)
prove it returns the same pose as the pure-Python ChaseCamera. Behaviour is
unchanged.
NOTE: merge only once a pycvc-gl package that ships NativeChaseCamera (built
against a cvcGL with #381's push-feed: feedTrackTarget/get_pose) is installed —
the currently-installed pycvc_gl extension predates it. Prepared, not merged.