Repository navigation
Fix the failure modes found in first field use - #1
Merged
Merged
Conversation
Three runs against github.com/gurnben/crush exposed a cluster of issues:
The audit runs 401'd immediately: the registry floor model resolved to
claude-mythos-5, which crush routed to an Anthropic provider with a bad
key. Runs now fail fast when the harness can verify the model is not
runnable (crush checks `crush models`), harness failures surface the
stderr tail so the provider error is visible without opening the journal,
and both are recorded in result.json as harness_error.
The threat-model run was healthy but aborted: crush emits output in rare
large chunks, so the monitor looked frozen for minutes and a single
ctrl+c killed a 9-minute audit. The status bar now shows time since last
output, and aborting requires a confirming second ctrl+c within six
seconds. Force-quitting the monitor tears the harness down and joins the
runner first, closing the "run produced no result" race.
Aborted and failed runs now still discover and validate their artifacts
(partial output and checkpoint state matter most exactly when a run dies),
and the run summary prints after the interactive monitor, not only in
plain mode.
Also: budget-policy parsing accepts the shipped sequence-form bands
(- {at, action}) that the real deployment file uses.
Verified end to end against a temp workspace wired to the real venv,
registry and budget policy with a fake harness; 34 tests, vet and
staticcheck clean.
💘 Generated with Crush
Assisted-by: Crush:rits/zai-org/glm-5-3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three runs against
github.com/gurnben/crush(two secure-code-audit, one threat-model) exposed a cluster of issues, all fixed here:claude-mythos-5, which crush routed to an Anthropic provider with an invalid key. Runs now fail fast when the harness can verify the model is not runnable (crush: checked againstcrush models), harness failures surface the stderr tail so the provider error is visible without opening the journal, and both are recorded inresult.jsonasharness_error.bands:(- {at: 1.5, action: warn}) that the real deployment file uses.Verification
go vetandstaticcheckclean; new tests cover the model-check fail-fast, stderr-tail surfacing, partial-output discovery, sequence-form bands, and crush model matching.Note: the companion deployment fix (mapping the
deep-auditandthreat-modelroles torits/zai-org/glm-5-3in the localmodel-registry.yaml, the mythos-class model this crush can authenticate to) was applied to~/.traust/configdirectly — the registry is designed for exactly that deployment customization.💘 Generated with Crush