Repository navigation
Install the secure-code-audit toolchain by default, pre-flight per run - #12
Merged
Merged
Conversation
The init wizard asked users to pick a scanner toolchain profile before they could know what they would run, and the answer is deterministic anyway: the secure-code-audit profile's toolset is a superset of the vuln-scan and triage profiles, so one profile covers every stage of every flow (audit and verify use its scanners; triage and patch need nothing beyond it). init now installs it by default — the wizard question is gone, and --toolchain none remains the explicit opt-out. Already-installed profiles are skipped so re-running init stays fast and idempotent. With the profile guaranteed by default, runs can hold it to account: every run (and therefore every flow stage) whose skill has a toolchain profile gets a cheap admin-toolchain-doctor pre-flight, and an incomplete profile surfaces as a non-fatal warning naming the profile, the coverage cost, and the fix — a degraded audit now says why it is degraded instead of silently producing thinner evidence. Also: run ids widened to a 6-hex random suffix — the 4-hex suffix collided ~8% of the time once a dozen runs shared a second (found by the uniqueness test going flaky in CI-race runs), and a collision meant a shared run directory. Verified live against the real workspace: the pre-flight fired on its incomplete profile, and the default install brought seven of eight tools healthy (one version-pinned upgrade left to the operator). Tests cover the warning path (non-fatal, names the fix), the clean path, and id uniqueness across repeated suites. 💘 Generated with Crush Assisted-by: Crush:rits/zai-org/glm-5-3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The init wizard asked users to pick a scanner toolchain profile before they could know what they would run — and the answer is deterministic anyway: the
secure-code-auditprofile's toolset is a superset of the vuln-scan and triage profiles, so one profile covers every stage of every flow (audit and verify use its scanners; triage and patch need nothing beyond it).secure-code-auditby default — the wizard question is gone;--toolchain noneremains the explicit opt-out; already-installed profiles are skipped so re-init stays fast.admin toolchain doctorcheck; an incomplete profile surfaces as a non-fatal warning naming the profile, the coverage cost ("the skill will run with reduced scanner coverage"), and the fix (traust-cli init). Degraded audits now say why they're degraded instead of silently producing thinner evidence.toolchain:field), alongside the existing role/min-model data.Verification
govulncheckupgrade remains operator-side (go install golang.org/x/vuln/cmd/govulncheck@latest).💘 Generated with Crush