Repository navigation
Wrap every remaining output path and fix the TTY detection - #5
Merged
Merged
Conversation
Several print paths bypassed the terminal-width wrapping added earlier: the full-permission and standalone-profile warnings (141 cells on a 60-column terminal), the run summary's harness-error block — which kept the source indentation of the harness's styled error boxes, so lines started mid-screen — artifact paths, doctor details, init step logs, and the skills table, whose four fixed columns cannot fit a narrow terminal at all. All of them now wrap to the measured width. The harness-error block is normalized for display: per-line trimming drops the error-box decoration so re-wrapped lines start at the left edge (the journal keeps the raw bytes), and the skills table drops its description column below ~77 columns instead of overflowing. Fixing this surfaced a hang: interactive screens gated on "stdin is a character device", which /dev/null satisfies — `traust-cli skills < /dev/null` opened the picker and waited forever. The check is now a real ioctl-based terminal test on both stdin and stdout. Verified by capturing PTY output at 60 columns and measuring every line's display width: zero over-width lines across run output, doctor and the skills table, with all continuation lines left-aligned. 💘 Generated with Crush Assisted-by: Crush:rits/zai-org/glm-5-3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several print paths bypassed the terminal-width wrapping added earlier, producing the odd, not-left-aligned output:
Fixes:
traust-cli skills < /dev/nullhung forever — interactive screens gated on "stdin is a character device", which/dev/nullsatisfies, so the picker opened and waited. The check is now a real ioctl-based terminal test (term.IsTerminal) on both stdin and stdout.Verification
💘 Generated with Crush