Repository navigation
feat(storage): persist portfolio forge facts for repository observation - #40
Conversation
|
LGTM for the Contracts storage change. Reviewed commit 2759c35. This adds persistence for the latest GitHub/GitLab repository observations and their audit-baseline context, while leaving derived repository state to Core. Verification performed:
Recommended test correction: add an actual PostgreSQL revision-1 -> revision-2 migration regression that verifies existing records survive and the migrated schema matches fresh initialization. The new upgrade test covers SQLite only, while test_postgres_migrate_bootstraps_empty_and_runs_a_step now exercises a synthetic revision-2 -> revision-3 step. Please obtain a PostgreSQL-enabled passing run as well. No functional defect was found in the exercised SQLite paths. PostgreSQL runtime behavior was not independently verified in this review. /lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chubirka, girish1430 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Repository observations need to retain forge measurements while recalculating current audit age, findings, risk and exposure. Add
portfolio_forge_factsto Contracts' SQLite and PostgreSQL storage schemas for XWING-2214.RepoStateis not persisted.Validation: lint passed; the latest test run passed 521 tests, with 43 skipped because local PostgreSQL was unavailable. An earlier PostgreSQL-enabled run passed 564 tests.
Merge order: this PR → Core #5 → Traust #58.