Repository navigation
feat: register_pattern() and friends (#108) - #109
Merged
Merged
Conversation
* `register_pattern()` / `unregister_pattern()` register patterns owned by the calling package (or the user) instead of setting the `ggpattern_geometry_funcs` / `ggpattern_array_funcs` global options. Its `defaults` argument sets pattern-specific default parameter values, which the builtin patterns now use. * Patterns may be referred to by qualified names e.g. `"gridpattern::stripe"`. * `prefer_pattern()` / `unprefer_pattern()` resolve name conflicts and `conflicting_patterns()` lists them. * `registered_patterns()`, `has_pattern()`, and `local_pattern()`. * `patternGrob()` caches the pattern resolved at creation so redraws still work if the pattern is later unregistered or masked. * Tests no longer leave a locked default graphics device open. closes #108 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
register_pattern()/unregister_pattern()register patterns owned bythe calling package (or the user) instead of setting the
ggpattern_geometry_funcs/ggpattern_array_funcsglobal options.Its
defaultsargument sets pattern-specific default parameter values,which the builtin patterns now use.
"gridpattern::stripe".prefer_pattern()/unprefer_pattern()resolve name conflictsand
conflicting_patterns()lists them.registered_patterns(),has_pattern(), andlocal_pattern().patternGrob()caches the pattern resolved at creation so redrawsstill work if the pattern is later unregistered or masked.
closes #108
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com