Repository navigation
transport: support Jetty 12 with Spring Boot BOM precedence - #154
Open
JingkaiTang wants to merge 1 commit into
Open
JingkaiTang wants to merge 1 commit into
JingkaiTang wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## JDK17/Springboot3 #154 +/- ##
=============================================================
- Coverage 85.78765% 85.69121% -0.09645%
+ Complexity 450 446 -4
=============================================================
Files 558 558
Lines 17330 17332 +2
Branches 1509 1509
=============================================================
- Hits 14867 14852 -15
- Misses 2463 2480 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| <jetty.alpn.boot.version>8.1.13.v20181017</jetty.alpn.boot.version> | ||
| <jetty.version>11.0.25</jetty.version> | ||
| <jetty.version>12.1.14</jetty.version> | ||
| <joda-time.version>2.7</joda-time.version> |
Collaborator
There was a problem hiding this comment.
SpringBoot 3.5 实际管理的 12.0.x，jetty是不是用12.0.x。SpringBoot 4.x应该有下一个trpc版本兼容，trpc2.x不用兼容这个
| @@ -21,10 +21,9 @@ | |||
| import com.tencent.trpc.core.rpc.def.DefProviderInvoker; | |||
| - name: Test with Maven | ||
| run: mvn clean install -Dmaven.test.skip=true -B -U --file pom.xml | ||
| - name: Test HTTP transport with Spring Boot BOM first | ||
| run: python3 trpc-transport/trpc-transport-http/src/test/it/boot-bom-first/run.py |
Collaborator
There was a problem hiding this comment.
用jetty 12.0.x这些测试是不是不需要了，trpc2.x版本不用考虑springboot4.x的问题
| cache: maven | ||
| - name: Test with Maven | ||
| run: mvn clean install -Dmaven.test.skip=true -B -U --file pom.xml | ||
| - name: Test HTTP transport with Spring Boot BOM first |
Collaborator
There was a problem hiding this comment.
用jetty 12.0.x这些测试是不是不需要了，trpc2.x版本不用考虑springboot4.x的问题
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152.
When a consumer imports Spring Boot's BOM before tRPC's BOM, Jetty 12 core artifacts are combined with the old Jetty 11 Servlet and HTTP/2 artifacts, causing HTTP server initialization to fail. Migrate the transport to Jetty 12 EE10 Servlet and renamed HTTP/2 artifacts, manage Jetty through its core and EE10 BOMs, and update the gateway WebApp dependency. The HttpExecutor contract, sessions and asynchronous Servlet responses are preserved.
The default Jetty version is 12.1.14; the Spring Boot baseline remains 3.5.0. Boot 3.x manages both core and EE10 versions. Boot 4 manages EE11 instead of EE10, so a 12.1-compatible EE10 default is needed when its BOM takes precedence.
Add an external consumer regression with Boot's BOM first and run it in the JDK 17/21 CI jobs. The matrix covers every stable patch of the current Boot minor line and later stable releases, plus the latest patch of the two preceding minor lines. This validates HTTP transport/BOM compatibility, not complete Boot 4 starter or gateway application support.
Validation on Corretto 21.0.5:
Upstream CI passed on the exact PR head: Maven install and Boot BOM matrix passed on JDK 17 and 21 (32 combinations / 416 test executions per JDK); PR regression tests passed on both JDKs, and Checkstyle passed.