Repository navigation
Conversation
Contributor
 [High impact] The PR appears safe to merge; no blocking issue remains. Reviews (2) · Last reviewed commit: "Treat only true as enabling rr.appServin..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Runs SERVICE_TYPE=RR_APP_SERVING_LAYER in its own Deployment and Service, mirroring the Retool Cloud split. Opt-in only: it needs an apps domain, wildcard DNS and a certificate the chart cannot supply. Requires the git server, since published assets live in the same blob storage. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Adds retool.appServingLayer.selectorLabels/labels so the Service, Deployment and pods carry app.kubernetes.io/name and app.kubernetes.io/instance, matching dbconnector and the workflow components. Selector is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Published-app backend functions (/_/api/executeV2) run on the js executor and call back through the workflow backend. Without these the serving layer fails with "Could not determine backend host" on self-hosted, where the org has no subdomain to fall back to. Values match the main backend. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Serves each editor sandbox at sandbox-<id>.<frontendWildcardDomain> on its own origin. Emitted as AGENT_SANDBOX_FRONTEND_WILDCARD_DOMAIN on the backend, workflows, and workers (via backendEnvVars) and on the proxy container. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
erichsu7
changed the title
rr.appServingLayer and rr.agentSandbox.frontendWildcardDomain
… frontendWildcardDomain as an override
erichsu7
changed the title
rr.appServingLayer and rr.agentSandbox.frontendWildcardDomainrr.appServingLayer and per-sandbox editor origins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds opt-in values for serving R² apps on their own origins on self-hosted, instead of the null-origin iframe.
rr.appServingLayerrunsSERVICE_TYPE=RR_APP_SERVING_LAYERin its own Deployment, Service and PDB, mirroring the Retool Cloud split.domainis rendered asRR_APP_DOMAINon the serving layer and the main backend. The serving layer also gets the blob storage, workflow backend and js executor settings it needs. It does not inheritrr.enabled, because it needs an apps domain with wildcard DNS and a certificate that only the operator can supply, and the render fails if it is enabled withoutdomainor the git server.rr.agentSandbox.wildcardSandboxesserves each editor sandbox atsandbox-<id>.sandboxes.<rr.appServingLayer.domain>by settingAGENT_SANDBOX_FRONTEND_WILDCARD_DOMAINon the backend and the agent-sandbox proxy.rr.agentSandbox.frontendWildcardDomain, the same key the cloud agent-executor chart uses, overrides the derived root, for example to put sandboxes on a separate domain.Everything defaults to off, so existing installs render the same.
Test plan: new CI fixture
ci/test-rr-app-serving-layer-option.yamlcovers the serving layer and the derived sandbox domain, andci/test-agent-sandbox-enabled-option.yamlnow sets thefrontendWildcardDomainoverride; both run through kubeconform. Rendered by hand to check that the stock andrr.enabled: trueinstalls create no serving-layer objects, that a missingdomainfails, thatwildcardSandboxeswithout the serving layer fails, and that a domain that isn't a lowercase hostname (uppercase, scheme, port, path, or trailing dot) fails in bothrr.appServingLayer.domainandrr.agentSandbox.frontendWildcardDomain.🤖 Generated with Claude Code