Skip to content

[fix][ap] Tell agent sandboxes what their actual CPU limit is #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamie-retool wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[fix][ap] Tell agent sandboxes what their actual CPU limit is #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/retool/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.12.1
version: 6.12.2
maintainers:
- name: Retool Engineering
email: engineering+helm@retool.com
Expand Down
3 changes: 3 additions & 0 deletions charts/retool/templates/deployment_agent_sandbox.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,9 @@ data:
,{"name": "SANDBOX_IDLE_TIMEOUT_MS", "value": "{{ $as.sandbox.sandboxIdleTimeoutMs }}"}
,{"name": "SANDBOX_GLOBAL_LIFETIME_MS", "value": "{{ $as.sandbox.sandboxGlobalLifetimeMs }}"}
,{"name": "SANDBOX_READY_TIMEOUT_MS", "value": "{{ $as.sandbox.sandboxReadyTimeoutMs }}"}
{{- if $as.sandbox.cpuAwareThreads }}
,{"name": "SANDBOX_CPU_LIMIT", "valueFrom": {"resourceFieldRef": {"resource": "limits.cpu", "divisor": "1"}}}

@greptile-apps greptile-apps Bot Oct 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Fractional CPU limits round up

When a user sets rr.agentSandbox.sandbox.resources.limits.cpu to a fractional value, divisor: "1" rounds SANDBOX_CPU_LIMIT up to a whole core. For example, a 1.5-core limit is reported as 2. Build tools using that value may start too many threads for the sandbox's limit. Pass a value that preserves the fraction in a unit the consumer expects.

{{- end }}
{{- if .Values.telemetry.enabled }}
,{"name": "STATSD_HOST", "value": "{{ include "retool.telemetry.fullname" . }}.{{ .Release.Namespace }}"}
,{"name": "STATSD_PORT", "value": "9125"}
Expand Down
3 changes: 3 additions & 0 deletions charts/retool/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,6 +1218,9 @@ rr:
limits:
cpu: '2'
memory: 4Gi
# Pass the sandbox container's CPU limit to build tools (tsc, esbuild, Rolldown, pnpm)
# so they size their thread pools to it. Without a CPU limit this is the node's CPU count.
cpuAwareThreads: true
# Idle timeout (ms) before an unassigned sandbox self-terminates.
sandboxIdleTimeoutMs: 600000
# Hard ceiling (ms) on total sandbox lifetime, regardless of activity. When
Expand Down
3 changes: 3 additions & 0 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,6 +1218,9 @@ rr:
limits:
cpu: '2'
memory: 4Gi
# Pass the sandbox container's CPU limit to build tools (tsc, esbuild, Rolldown, pnpm)
# so they size their thread pools to it. Without a CPU limit this is the node's CPU count.
cpuAwareThreads: true
# Idle timeout (ms) before an unassigned sandbox self-terminates.
sandboxIdleTimeoutMs: 600000
# Hard ceiling (ms) on total sandbox lifetime, regardless of activity. When
Expand Down
Loading