Repository navigation
Keep the original error when a transaction is already rolled back - #244
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database.transaction()runsROLLBACKwhenever the wrapped function throws. If SQLite has already rolled the transaction back (for example afterINSERT OR ROLLBACKorRAISE(ROLLBACK, ...)), thatROLLBACKfails withcannot rollback - no transaction is activeand replaces the real error.This change runs
ROLLBACKonly whiledb.inTransactionis true, which matches better-sqlite3. It applies to bothlibsqlandlibsql/promise.Changes
compat.jsandpromise.js: skipROLLBACKin the transaction wrapper when no transaction is active.integration-tests/tests/sync.test.jsandasync.test.js: add a test that triggersINSERT OR ROLLBACKinside a transaction and expectsSQLITE_CONSTRAINT_PRIMARYKEY. The sync test also passes against better-sqlite3 (PROVIDER=sqlite).Testing
test:libsqlandtest:asyncwithSQLITE_ERROR: cannot rollback - no transaction is active.test:sqlite53,test:libsql53,test:async68,test:extensions29,test:concurrency4,test:connections2.Fixes #243