Skip to content

Fix Windows compilation in libsql-sys - #2184

Merged
penberg merged 1 commit into
tursodatabase:mainfrom
jayvdb:fix-windows
Nov 6, 2025
Merged

penberg merged 1 commit into
tursodatabase:mainfrom
jayvdb:fix-windows

Conversation

@jayvdb

@jayvdb jayvdb commented Nov 2, 2025 •

Copy link
Copy Markdown
Contributor

This occurs on the latest released version 0.9.24 :

error[E0599]: no method named `to_str` found for type parameter `impl AsRef<Path>` in the current scope
Error:    --> C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\libsql-sys-0.9.24\src\connection.rs:287:18
    |
200 |           path: impl AsRef<Path>,
    |                 ---------------- method `to_str` not found for this type parameter
...
286 |               let path = path
    |  ________________________-
287 | |                 .to_str()
    | |                 -^^^^^^ method not found in `impl AsRef<Path>`
    | |_________________|
    |

For more information about this error, try `rustc --explain E0599`.
error: could not compile `libsql-sys` (lib) due to 1 previous error

@jayvdb jayvdb changed the title Fix Windows compilation Fix Windows compilation in libsql-sys Nov 2, 2025
@jayvdb

jayvdb commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

ping @penberg , this is occurring in the released version

@penberg
penberg added this pull request to the merge queue Nov 6, 2025
@penberg

penberg commented Nov 6, 2025

Copy link
Copy Markdown
Collaborator

Thanks @jayvdb!

Merged via the queue into tursodatabase:main with commit a060476 Nov 6, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants