Repository navigation
Conversation
The url 2.5.4+ crate pulls idna 1.x -> idna_adapter -> icu_* 2.2.0, which require rustc 1.86. A fresh dependency resolution (e.g. the Docker build, which did not pass --locked) would select those and fail against the 1.85.0 toolchain pinned in rust-toolchain.toml. This patch bump the workspace to resolver to fix this issue. Note that as `ext/crr` uses Rust nightly that does not support the new resolver, we had to add configure the projects as workspaces, to avoid `cargo` dicovering the unsupported resolver in top-level Cargo.toml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The url 2.5.4+ crate pulls idna 1.x -> idna_adapter -> icu_* 2.2.0, which
require rustc 1.86. A fresh dependency resolution (e.g. the Docker build,
which did not pass --locked) would select those and fail against the 1.85.0
toolchain pinned in rust-toolchain.toml.
Bump the workspace to resolver = "3". With no rust-version declared, cargo's
MSRV-aware resolver falls back to the installed toolchain version (1.85.0, per
rust-toolchain.toml) and resolves to the latest compatible deps. Also pass
--locked in the Dockerfile so the image builds the exact pinned dependency
tree.