Repository navigation
feat(dtc): notify the driver when the scan on connect finds codes - #238
Merged
Merged
Conversation
… to the vehicle Phone notification (opens the DTC list) and an Android Auto toast for codes the vehicle's history has not seen before. Replaces the "DTC available" toast, which fired on every connect while any code was stored. New setting pref.dtc.notify_new_codes, on by default.
The first scan of a vehicle (e.g. after a fresh install) has no history to compare with and announced nothing; it now lists all codes as "Trouble codes found". Whether a scan is the first is read before it is stored: history replaces a connect scan equal to the previous one, so a vehicle with unchanged codes keeps a single scan and would otherwise re-announce them on every connect. Notification shows 8 codes, the AA toast 3, then "+N more".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phone notification (opens the DTC list) and an Android Auto toast for codes the vehicle's history has not seen before. Replaces the "DTC available" toast, which fired on every connect while any code was stored. New setting pref.dtc.notify_new_codes, on by default.