Repository navigation
Feat/dtc clear module - #241
Merged
Merged
Conversation
An expanded module with codes gets a "Clear codes in <module>" row that clears that module alone after one confirmation. A read or clear of some modules now refreshes only those: the other modules keep their codes instead of vanishing from the list. Before any clear, a recent engine speed or vehicle status reading showing a running engine adds a warning (phone and AA), since most modules refuse the clear then.
Clear codes in <module>" sat under the module's last code, so a module with many codes pushed it off screen. It now sits right under the module header, above the codes.
"Clear this module" is now a small outlined button under the module header, red only in its outline and icon so it does not read as another code. The DTC dialog's Close label sat a line high: the shared string carries a second line for the trip dialog, so the DTC dialog gets its own one-line label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.