Repository navigation
Harden report PDF export and split grown text across pages - #46
Merged
Merged
Conversation
- Rust rejects PNGs that declare more than 50 megapixels before allocating, caps the decoder at 64 MiB, and reports why an image prints as a placeholder; prepare_report_pdf runs as an async command. - 16-bit PNGs no longer pass through (PDF 1.4 allows 8 bits); Rust strips them. - Bands with grown text split between lines across pages instead of running past the footer; keepTogether still moves a band that fits a page. - A required parameter passed as null prompts; Can grow is hidden on page header and footer text. - Reports guide and decision record describe Can grow, the fallback fonts and the exact excluded scripts, PNG support and the parameter prompt.
|
🚀 Web preview: https://preview-46.ixtable.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/BitsPerComponent 16, which needs PDF 1.5; Rust strips them to 8 bits.prepare_report_pdfnow runs as an async command, off the main thread.nullnow prompts, and Can grow is hidden on page header and footer text, where it has no effect.web/docs/guides/reports.mdanddocs/decisions/report-engine.mdnow describe Can grow, the bundled fallback fonts with the exact excluded scripts, PNG support, and the run-time parameter prompt. New Rust tests cover huge, truncated, 16-bit and interlaced PNGs, and new unit tests cover the page split. All 656 unit tests pass, the report and golden snapshot integration tests pass unchanged, andcargo test --lib report_pdfpasses 11 of 11.Generated by Claude Code