4634 add fuel ion equilibrium constraint - #4639
Open
grmtrkngtn wants to merge 3 commits into
Open
grmtrkngtn wants to merge 3 commits into
grmtrkngtn wants to merge 3 commits into
Conversation
…date associated outputs, labels and tests.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4639 +/- ##
=======================================
Coverage 49.92% 49.92%
=======================================
Files 151 151
Lines 30225 30242 +17
=======================================
+ Hits 15089 15099 +10
- Misses 15136 15143 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@grmtrkngtn could you possibly explain (and justify) why the regression tests have changed results here? Its not immediately obvious why this has happened |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes fuel-ion equilibrium an explicit equality constraint in PROCESS.
Previously, the required plasma fuelling rate was calculated and set internally from the fusion rate and burnup fraction. This hides one of the coupled relationships required for PROCESS to arrive at a self-consistent solution.
The change separates:
molflow_plasma_fuelling, representing the plasma fuelling rate;molflow_plasma_fuelling_equilibrium, calculated from the plasma state.Constraint 93 then explicitly enforces fuel-ion equilibrium by requiring:
molflow_plasma_fuelling = molflow_plasma_fuelling_equilibriumThe equilibrium requirement is calculated in the physics model, while the constraint simply compares the two quantities.
Motivation
This is part of the work required to introduce a PROCESS solution mode for uncertainty-quantification evaluations.
For UQ, we want to evaluate PROCESS at sampled inputs without performing a full design optimisation. PROCESS must therefore be able to solve the coupled equations required for a physically self-consistent plant state independently of the optimisation problem.
Making fuel-ion equilibrium an explicit closure equation is one step towards separating:
solving the PROCESS model for a self-consistent state, from
optimising the design.
This will allow a future solution mode to solve the required internal equilibrium equations for each UQ sample while keeping the sampled/design quantities fixed.