Repository navigation
Release 2.2.14: ambiguous currency symbols on data v2.2.1 - #47
Merged
Merged
Conversation
SymbolPresentations carries the optional ambiguous flag of the new currency symbol data (bare dollar, yen signs, franc Fr.), the data submodule pins v2.2.1, and VERSION/UNITS_DATA_VERSION track it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SymbolPresentationsgains the optionalambiguousboolean, exposing the new currency symbol data (Add ambiguous currency symbol presentations (bare dollar, yen, franc) unitsdb#141, data tagv2.2.1): USD bare$, CNYCN¥/bare¥, JPY¥, CHFFr.— strict-unit consumers skip ambiguous presentations, prose style-enforcement consumers match them.v2.2.1;VERSION2.2.14;UNITS_DATA_VERSION2.2.1.Resolves the data side of #140.
Test plan
bundle exec rspec— 871 examples, 0 failures (new: ambiguous symbols parsed from the shipped data)bundle exec rake— specs + rubocop cleanv2.2.14after merge (rubygems workflow publishes)