Repository navigation
Build against unitsml-rs cdfbcc3 and replay the Ruby point/difference cases - #5
Merged
Merged
Conversation
… cases unitsml-rs main cdfbcc3 adds two point/difference fixes that match unitsml-ruby: a difference minus an absolute point is a difference (85a4485, unitsml/unitsml-rs#3), and a difference plus a point answers in the difference's unit (cdfbcc3, unitsml/unitsml-rs#4). Cargo.lock is unchanged since 4aa5f3f; the unitsdb-rs, asciiunits-python 9a405a5 and F40 corpus pins are unchanged. tests/point-difference-vectors.json holds the 24 point/difference add and subtract cases from unitsml-ruby 2ec9583. tests/test_point_difference.py checks each case's exact magnitude, unit and scale against the installed wheel.
suleman-uzair
marked this pull request as ready for review
November 12, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the native pin in
native-source.jsonandci/native-source.jsonfromunitsml/unitsml-rs14c1707 to main cdfbcc3. That brings in two point/difference fixes that match unitsml-ruby:Cargo.lockis unchanged (sha256 949a6198…), and so are the unitsdb-rs, asciiunits-python 9a405a5 (Parsanol 5206a33) and F40 corpus pins.Changes
native-source.json: native source cdfbcc3. The fallback library hash is a local 1.95.0 build; CI still validates the binary it builds through the build receipt.tests/point-difference-vectors.jsonholds the 24 point/difference add and subtract cases recorded from unitsml-ruby 2ec9583. They cover degC and K operands with point and difference scale on each side.tests/test_point_difference.pychecks that the installed wheel returns, for each case, the same exact magnitude, unit and scale as Ruby.tests/test_dependency_pins.pyexpects the unitsml native build from cdfbcc3.