re #228 fix(dist): allow psr/http-message ^1.1 in univeros/http and univeros/cookie - #229
Merged
Merged
Conversation
…niveros/cookie univeros/http and univeros/cookie pinned psr/http-message ^2.0, which can never be satisfied alongside their own transitive deps neomerx/cors-psr7 (^1.0) and relay/relay (~1.0) — both PSR-7 v1 only. So both splits were uninstallable as standalone published packages: `composer require univeros/http` (and any module scaffolded by `bin/altair module:new`) failed to resolve. The framework already runs on psr/http-message 1.1 (MessageInterface:: getProtocolVersion has no return type → PSR-7 v1.x; CI is green on it). The monorepo root, laminas/laminas-diactoros 3.8, guzzle, and the sibling Altair packages (Idempotency/Webhooks/Observatory/Observability) all use ^1.1 || ^2.0; http and cookie were the only outliers. The bug stayed hidden because the monorepo `replace`s the splits and host apps depend on the univeros/framework bundle (root constraint already ^1.1 || ^2.0). Loosen both to `^1.1 || ^2.0`. No code change — resolution is unchanged (neomerx/relay still cap the graph at 1.1). Distinct from the longer-term #209 work to replace neomerx and move fully to psr/http-message ^2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #228.
Problem
composer require univeros/http— and therefore any module scaffolded bybin/altair module:new(it requires the splituniveros/http) — fails to resolve:Root cause
univeros/httpanduniveros/cookiepinpsr/http-message: ^2.0, but their own transitive deps cap the graph at PSR-7 v1:neomerx/cors-psr7→psr/http-message ^1.0relay/relay→psr/http-message ~1.0The framework genuinely runs on psr/http-message 1.1 (
MessageInterface::getProtocolVersion()has no return type → v1.x; CI green). The monorepo root,laminas/laminas-diactoros 3.8, guzzle, and the sibling Altair packages (Idempotency/Webhooks/Observatory/Observability) already use^1.1 || ^2.0— http and cookie were the only outliers. The bug was hidden because the monoreporeplaces the splits (their constraints ignored) and host apps depend on theuniveros/frameworkbundle (root constraint already^1.1 || ^2.0); a module that requires the splituniveros/httpdirectly is the first consumer to hit it.Fix
in
src/Altair/Http/composer.jsonandsrc/Altair/Cookie/composer.json. No code change — resolution is unchanged (neomerx/relay still pin the graph to 1.1), proven bycomposer update --dry-run(no psr/http-message movement) and a green cache-freecs/stan/rectorlocally.Distinct from #209's longer-term work to replace/fork
neomerx/cors-psr7and move fully to psr/http-message ^2.0.Test plan
composer cs/composer stan(level 8) /composer rector— clean.composer require univeros/httpresolves in a fresh project;bin/altair module:new→composer installsucceeds.