Skip to content

carousel: subscribe before calling setApi #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deebov merged 1 commit into from
Sep 26, 2026
Merged

carousel: subscribe before calling setApi #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions components/application/carousel/carousel-base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,8 @@ const CarouselRoot = ({ orientation = "horizontal", opts, setApi, plugins, class
[scrollPrev, scrollNext],
);

useEffect(() => {
if (!api || !setApi) return;

setApi(api);
}, [api, setApi]);

// Subscribe before handing the api to setApi: effects run in order, so a consumer that
// scrolls as soon as it gets the api must find these listeners already attached.
useEffect(() => {
if (!api) return;

Expand All @@ -129,6 +125,12 @@ const CarouselRoot = ({ orientation = "horizontal", opts, setApi, plugins, class
};
}, [api, onInit, onSelect]);

useEffect(() => {
if (!api || !setApi) return;

setApi(api);
}, [api, setApi]);

return (
<CarouselContext.Provider
value={{
Expand Down
Loading