Ship creation code in the gem at 0.2.0 - #7
Merged
Merged
Conversation
The gem carried ABIs and verification sources only, on the reasoning that a Ruby consumer never deploys. Rails does hand creation code to a browser that deploys the set, and it read that code from its own copy of the artifacts. One copy has to go, so the gem carries artifacts/ now and Rails can drop its copy. artifact and bytecode read the new files. A test digests the shipped creation code against the manifest, which records it as raw bytes, so a truncated or re-encoded copy fails the build. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Ruby gem now ships
artifacts/(creation code) alongside the ABIs, manifests and verification sources, and exposesartifact(release, contract)andbytecode(release, contract).Notes
abiandbytecodein the shipped artifacts are byte-identical to the copies Rails serves today.manifest.artifacts[].creationCode.sha256, which the manifest records over raw bytes, so a truncated or re-encoded copy fails the build.artifacts/and does not change.Made with Cursor