Repository navigation
Point the Input and Output nodes toward their pins - #68
Merged
Merged
Conversation
Draw the Input and Output nodes as pentagons pointing toward their pin, which tells them apart without the component name above them, and drop the chip around their label. Clicking an Input node anywhere now increments its value in play mode. Move the stroke and fill of the node shapes into a CSS module shared by the default and interface renderers. The node renderer gives the `selected` class to the element wrapping a node, so the renderers no longer receive the selection state. Disable noPropertyAccessFromIndexSignature, which forbids accessing the classes of a CSS module with dot notation.
Deploying create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee with
|
| Latest commit: |
294c5f2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1d423872.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
| Branch Preview URL: | https://interface-node-shape.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draw the Input and Output nodes as pentagons pointing toward their pin, which tells them apart without the component name above them, and drop the chip around their label. Clicking an Input node anywhere now increments its value in play mode.
Node/style.module.css, shared by the default and interface renderersselectedclass to the element wrapping a node in the node renderer, and removenodeStatefrom the props of the renderersnoPropertyAccessFromIndexSignatureso that the classes of a CSS module can be accessed with dot notation