Repository navigation
Show the values of the Input and Output nodes bit by bit - #72
Merged
Merged
Conversation
Deploying create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee with
|
| Latest commit: |
bac6103
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3be04d21.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
| Branch Preview URL: | https://interface-value-bits.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value display of the Input and Output nodes is extracted into a
Valuecomponent, and values up to 8 bits are now shown bit by bit.ON/OFFtoggle.On the Input node, clicking a bit toggles it, and clicking a value of more than 8 bits increments it as before. The clicks are now handled by buttons in the
Valuecomponent instead of the whole node shape, so clicking elsewhere on the node selects or drags it as usual. The Output node shows the value without buttons.Other changes:
primaryLight(primary.lightas calculated by MUI) to the shared colors, used for the bits that are on.clsxto the dependencies.