Repository navigation
Edit the value of the Input node in a popover shared with the Const node - #73
Merged
Merged
Conversation
Deploying create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee with
|
| Latest commit: |
c20fed4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c94b607c.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
| Branch Preview URL: | https://value-editor.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value editor of the Const node is extracted into a shared
ValueEditorcomponent, and the Input node now uses it to edit values of more than 8 bits.ValueEditoredits a value as text in binary, hexadecimal or UTF-8. The value is changed with the Apply button placed next to the mode buttons. WithreadOnly, the text cannot be edited, but the mode can still be changed.bitWidth, the value is padded with leading zeros to the bit width, and values that do not fit are rejected.ValueEditor, and is read-only outside the edit mode.ValueEditorin a popover. Clicking the value no longer increments it, andwrappingIncrementSimulationValueis removed.