Skip to content

feat: limit Excel uploads to 10 MB - #184

Merged
tknkaa merged 2 commits into
mainfrom
fix/excel-upload-limit
Nov 9, 2026
Merged

tknkaa merged 2 commits into
mainfrom
fix/excel-upload-limit

Conversation

@tknkaa

@tknkaa tknkaa commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Excelインポートのサイズ上限がなかったため、最大10 MBに制限します。サーバー側でExcelJSの解析前に拒否し、画面にも上限を表示します。リポジトリにはリバースプロキシ側のアップロード上限設定がないため、アプリ側で明示します。

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 49.7% 1670 / 3360
🔵 Statements 49.1% 1867 / 3802
🔵 Functions 37.71% 367 / 973
🔵 Branches 36.4% 850 / 2335
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/lib/server/my-notebooks/actions.server.ts 70.12% 64.92% 66.66% 70.67% 98, 104-131, 136-140, 185, 324, 407, 417, 434, 458-467, 486-556, 570, 590-611, 622, 695-703, 724-776
app/lib/shared/excel-constraints.ts 100% 100% 100% 100%
app/lib/shared/excel.ts 80.26% 52.17% 85.71% 80% 34, 38-51, 76, 83, 96, 113, 120, 150
Generated in workflow #79 for commit e7e1fd1 by the Vitest Coverage Report Action

@tknkaa
tknkaa merged commit 4991f44 into main Nov 9, 2026
8 checks passed
@tknkaa
tknkaa deleted the fix/excel-upload-limit branch November 9, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant