updated migration fallback to legacy

[ArnabChatterjee20k]

Summary by CodeRabbit

• Refactor
  • Updated the default value for database type from 'sql' to 'legacy' when the type is not specified during database creation, import, or export.

[coderabbitai]

Walkthrough

The changes update the default value for the 'type' property of database resources in the migration process. Previously set to 'sql', the default is now 'legacy' across the Appwrite destination, Appwrite source, and the Database resource class. No other logic or control flow is modified.

Changes

Cohort / File(s)	Change Summary
Appwrite Destination Default Type src/Migration/Destinations/Appwrite.php	Changed the default 'type' value in the createDatabase method from 'sql' to 'legacy'.
Database Resource Default Type src/Migration/Resources/Database/Database.php	Updated the fromArray static factory method to default the type property to 'legacy' instead of 'sql'.
Appwrite Source Default Type src/Migration/Sources/Appwrite.php	Modified the fallback 'type' assigned during database export from 'sql' to 'legacy'.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• Add 'type' property to Database resource and update Appwrite source #103: Introduced the 'type' property and its integration into the Database class and Appwrite source, which this PR builds upon by changing the default value.

Poem

A hop and a skip, a quick little fix,
From 'sql' to 'legacy', the code now clicks.
Databases march in a brand new parade,
With defaults refreshed, migrations remade.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9a7e87 and fa3f3ca.

📒 Files selected for processing (3)

• src/Migration/Destinations/Appwrite.php (1 hunks)
• src/Migration/Resources/Database/Database.php (1 hunks)
• src/Migration/Sources/Appwrite.php (1 hunks)

🧰 Additional context used

🧠 Learnings (7)

📓 Common learnings

Learnt from: ItzNotABug
PR: utopia-php/migration#80
File: src/Migration/Sources/Supabase.php:300-308
Timestamp: 2025-06-28T09:47:58.757Z
Learning: In the utopia-php/migration codebase, during the terminology swap from Collection/Attribute/Document to Table/Column/Row, the user ItzNotABug prefers to keep the existing query logic unchanged even if it becomes semantically incorrect with the new naming. The focus is purely on resource type renaming, not on fixing logical issues that become apparent after the terminology change.

Learnt from: ItzNotABug
PR: utopia-php/migration#80
File: src/Migration/Sources/Appwrite.php:843-851
Timestamp: 2025-06-28T09:47:08.333Z
Learning: In the utopia-php/migration codebase, during the terminology swap from Collection/Attribute/Document to Table/Column/Row, the class constructors and method parameters use the new terminology (like "relatedTable"), but the underlying data structures and API responses still use the legacy keys (like "relatedCollection"). This is an intentional design pattern to allow gradual migration while maintaining compatibility with existing data sources.

Learnt from: ItzNotABug
PR: utopia-php/migration#80
File: src/Migration/Sources/Appwrite/Reader/API.php:8-8
Timestamp: 2025-06-28T09:47:11.436Z
Learning: In the Appwrite migration codebase, commented-out Tables service references (import statements and constructor parameters) are intentionally kept for future implementation when the Tables service becomes available in the Appwrite SDK, rather than being dead code that should be removed.

📚 Learning: in the utopia-php/migration codebase, during the terminology swap from collection/attribute/document...

Learnt from: ItzNotABug
PR: utopia-php/migration#80
File: src/Migration/Sources/Supabase.php:300-308
Timestamp: 2025-06-28T09:47:58.757Z
Learning: In the utopia-php/migration codebase, during the terminology swap from Collection/Attribute/Document to Table/Column/Row, the user ItzNotABug prefers to keep the existing query logic unchanged even if it becomes semantically incorrect with the new naming. The focus is purely on resource type renaming, not on fixing logical issues that become apparent after the terminology change.

Applied to files:

• src/Migration/Destinations/Appwrite.php
• src/Migration/Sources/Appwrite.php
• src/Migration/Resources/Database/Database.php

📚 Learning: in the utopia-php/migration codebase, during the terminology swap from collection/attribute/document...

Learnt from: ItzNotABug
PR: utopia-php/migration#80
File: src/Migration/Sources/Appwrite.php:843-851
Timestamp: 2025-06-28T09:47:08.333Z
Learning: In the utopia-php/migration codebase, during the terminology swap from Collection/Attribute/Document to Table/Column/Row, the class constructors and method parameters use the new terminology (like "relatedTable"), but the underlying data structures and API responses still use the legacy keys (like "relatedCollection"). This is an intentional design pattern to allow gradual migration while maintaining compatibility with existing data sources.

Applied to files:

• src/Migration/Destinations/Appwrite.php
• src/Migration/Sources/Appwrite.php
• src/Migration/Resources/Database/Database.php

📚 Learning: in the appwrite migration codebase, commented-out tables service references (import statements and c...

Learnt from: ItzNotABug
PR: utopia-php/migration#80
File: src/Migration/Sources/Appwrite/Reader/API.php:8-8
Timestamp: 2025-06-28T09:47:11.436Z
Learning: In the Appwrite migration codebase, commented-out Tables service references (import statements and constructor parameters) are intentionally kept for future implementation when the Tables service becomes available in the Appwrite SDK, rather than being dead code that should be removed.

Applied to files:

• src/Migration/Destinations/Appwrite.php
• src/Migration/Sources/Appwrite.php

📚 Learning: in the utopia-php/migration codebase, the utopia database package does not have a memory adapter. wh...

Learnt from: abnegate
PR: utopia-php/migration#0
File: :0-0
Timestamp: 2025-07-30T12:06:02.331Z
Learning: In the utopia-php/migration codebase, the Utopia Database package does not have a Memory adapter. When testing classes that require a Database instance (like CSV), use PHPUnit's createMock() method to create proper mocks instead of trying to instantiate real database adapters.

Applied to files:

• src/Migration/Sources/Appwrite.php
• src/Migration/Resources/Database/Database.php

📚 Learning: in the utopia-php/migration codebase, the `fromarray` method is not used on row objects, so mismatch...

Learnt from: ItzNotABug
PR: utopia-php/migration#80
File: src/Migration/Resources/Database/Row.php:60-60
Timestamp: 2025-06-28T09:45:36.026Z
Learning: In the utopia-php/migration codebase, the `fromArray` method is not used on Row objects, so mismatches between `jsonSerialize()` output keys and `fromArray()` input expectations for Row class are not problematic.

Applied to files:

• src/Migration/Resources/Database/Database.php

📚 Learning: in the utopia-php/migration codebase, invalid numeric values (like null) in parsed data are acceptab...

Learnt from: ItzNotABug
PR: utopia-php/migration#81
File: src/Migration/Sources/CSV.php:215-233
Timestamp: 2025-07-02T06:24:50.844Z
Learning: In the utopia-php/migration codebase, invalid numeric values (like null) in parsed data are acceptable because the underlying database structure validator will catch and handle these validation errors, so explicit filtering during parsing is not required.

Applied to files:

• src/Migration/Resources/Database/Database.php

🧬 Code Graph Analysis (1)

src/Migration/Destinations/Appwrite.php (1)

src/Migration/Resources/Database/Database.php (1)

• getType (88-91)

🔇 Additional comments (3)

src/Migration/Resources/Database/Database.php (1)

49-49: LGTM! Coordinated default value update.

The change from 'sql' to 'legacy' as the default database type is consistent with the coordinated updates across the migration system mentioned in the AI summary.

src/Migration/Destinations/Appwrite.php (1)

340-340: LGTM! Consistent fallback value update.

The default fallback from 'sql' to 'legacy' aligns with the coordinated changes across the migration system, maintaining consistency with the Database resource class changes.

src/Migration/Sources/Appwrite.php (1)

728-728: LGTM! Completes the coordinated migration type update.

The fallback from 'sql' to 'legacy' in the Database constructor maintains consistency across the entire migration pipeline - source, destination, and resource layers now all use the same default type value.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.