fix(cdn): recover Fastly certificates and preserve DNS failure details - #222
Open
HarshMN2345 wants to merge 4 commits into
Open
fix(cdn): recover Fastly certificates and preserve DNS failure details#222HarshMN2345 wants to merge 4 commits into
HarshMN2345 wants to merge 4 commits into
Conversation
HarshMN2345
changed the title
HarshMN2345
marked this pull request as ready for review
September 7, 2026 13:01
HarshMN2345
requested review from
Meldiron,
abnegate,
eldadfux and
loks0n
as code owners
September 7, 2026 13:01
Meldiron
reviewed
Sep 8, 2026
| * @param array{resource:array<string, mixed>,included:array<int, array<string, mixed>>} $subscription | ||
| * @return list<string>|null | ||
| */ | ||
| private function getSubscriptionDomains(array $subscription): ?array |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fastly can return
service_id: nullfor both classic domains and unlinked versionless domains. The managed provider previously treated both as classic, so an orphan could remain without a service association or TLS subscription indefinitely. It now links a confirmed orphan to the configured service before requesting TLS.Ownership checks preserve classic exact and wildcard routes across services, existing routing configurations, and TLS-first transfers between services. Repair requires unrestricted token and user visibility through
/tokens/self,/current_user, and the complete service inventory. Failed lookups, malformed responses, incomplete results, and insufficient permissions stop mutation.Certificate polling now reads the subscription's referenced TLS authorizations. An explicit failed subscription or blocked authorization throws
Utopia\Cdn\Exception\Certificate, carrying its status, provider instructions, and relevant DNS record types, names, and values. Pending warnings remain pending; an issued subscription stays issued even if an included authorization is stale. Unrelated authorization details are excluded.Deletion removes owned orphan records before their TLS subscription so retries can finish partial cleanup. It preserves domains belonging to other services, routing configurations, and wildcard routes, and refuses to delete shared TLS subscriptions. Missing-domain cleanup also checks classic ownership before removing TLS.
Validation:
bin/monorepo check cdn: Pint, PHPStan, and Rector pass.bin/monorepo validateandgit diff --checkpass.The CDN suite uses scripted HTTP responses; it does not perform live Fastly, DNS, or CA E2E requests.
Companion Appwrite retry handling: appwrite/appwrite#13467. Cloud status handling: https://github.com/appwrite-labs/cloud/pull/5639.