Repository navigation
extract: print only the member names with -v - #420
jayhemnani9910 wants to merge 2 commits into
Conversation
-xv printed an 'Extracting archive: NAME' line before the members. GNU tar prints only the member names.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Merging this PR will not alter performance1 warning
Comparing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 96.84% 98.25% +1.40%
==========================================
Files 11 15 +4
Lines 1492 2006 +514
Branches 29 39 +10
==========================================
+ Hits 1445 1971 +526
+ Misses 46 34 -12
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| #[test] | ||
| fn test_extract_verbose_lists_only_members() { |
There was a problem hiding this comment.
almost the same as test_extract_verbose just below
could you please switch that one to stdout_only instead of adding a new test?
There was a problem hiding this comment.
Done in f3fa931: removed the new test and switched test_extract_verbose to stdout_only.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
tar -xvf archive.tarprints anExtracting archive: archive.tarline before the member names. GNU tar prints only the names:Scripts that read the extracted names from
-xv(or count them) get an extra line that isn't a file. The line came with the first extract implementation;-cvand-tvnever had one.The line is removed, and with it the
archive_pathparameter ofextract_archive, which was only used for it.New test
test_extract_verbose_lists_only_memberschecks the exact output (fails on main).cargo test --workspace: all pass (test_tar 69, 68 on main),cargo clippy --workspace --all-targetsclean (the bench caller is updated too).