Repository navigation
Conversation
…oil-surface distances, mean squared curvature
The per-order einsum under vmap made XLA's GPU backend emit an illegal memory access in the reverse pass of gamma_dash for 40 curves (5 base coils, nfp 4, stellarator symmetric) at every segment count; 24 and 32 curves and the CPU were unaffected. Same values (checked against spectral derivatives of gamma).
…, CoilLimits, coil_constraint CoilDesign maps one design vector (relative base-coil currents, additive unscaled Fourier coefficients) to coils and their BiotSavart field; CoilLimits turns lengths, curvatures, the mean squared curvature and the coil-coil, self and coil-surface distances of this PR into scaled inequality rows; coil_constraint makes pure-coil rows a SciPy NonlinearConstraint (reverse-mode or chunked forward-mode Jacobian), for SLSQP.
Member
|
Hi Hongke, main has moved since you opened this, and the PR now conflicts in tests/test_coils.py. I opened #253 against your branch that merges main in and resolves it. You and main each appended a test at the end of the file, so I kept both: your curve-derivative test and main's zero-currents test. Under JAX_ENABLE_X64=1 with -n 2, tests/test_coils.py gives 34 passed, and test_coil_design.py plus test_objective_functions.py give 27 passed. Merging #253 into your branch clears the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose individual coil-distance constraints for constrained optimization. The CPU suite reported 387 passes and one skip, with the optional Optuna module excluded.
Measurements and test conditions