Skip to content

Remove dead and duplicated code - #193

Open
rogeriojorge wants to merge 3 commits into
mainfrom
refactor/remove-dead-code
Open

rogeriojorge wants to merge 3 commits into
mainfrom
refactor/remove-dead-code

Conversation

@rogeriojorge

Copy link
Copy Markdown
Member

Removes code that nothing in essos, tests, examples, docs or the README uses: Particles.InitializeParticlesAroundSurfaceAxis, ScaledConstraint and the ALM_model_jaxopt_lbfgsb alias, surfaces.toroidal_flux/poloidal_flux/nested_lists_to_array/evaluate_rphiz/plot_scalar_on_flux_surface/signed_distance_from_surface_extras, util.roots_scipy, DiscretizedCoils.to_Coils, the HBAR/BOLTZMANN constants, Electric_field_flux.E_theta/E_phi, unused imports and variables, and commented-out blocks.

The Pareto/parallel-coordinate/history/importance plot methods now share one figure-saving helper, and the collision drift/diffusion functions share one species-sum helper. A before/after run of every plot method gave the same output files.

setup.py and requirements.txt are deleted; dependencies stay in pyproject.toml, which gains a test extra, and CI installs .[multiobjective,test].

Net change: 18 files changed, 104 insertions(+), 604 deletions(-). Tests: 384 passed, 1 skipped, 1 xfailed, same as main; flake8 E9,F63,F7,F82 is clean.

Drop unreferenced functions, classes, constants and unused imports/variables,
commented-out blocks, setup.py and requirements.txt (declared in pyproject
with a new test extra); share the plot-saving and collision-rate helpers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant