Repository navigation
Simplify the native Dopri solvers - #195
Open
rogeriojorge wants to merge 10 commits into
Open
rogeriojorge wants to merge 10 commits into
rogeriojorge wants to merge 10 commits into
Conversation
- One dense-output path for both methods: the Dopri5 quartic is expressed as the same per-stage polynomial table as Dopri8, so the Dopri5 branch in the CUDA kernel and the separate Python interpolants go away. - Remove the unrolled/loop stage duplication (stage_execution), the public one-step functions and their interpolation wrappers, solve_rk45 and solve_dopri8 (use method=), and the unused record_steps/step_ts history. - Validate solve_rk inputs from a single list of conditions that raises for concrete values and sets INVALID_INPUT for traced ones. - Trim the README section and the tests: add fixed-step Diffrax agreement, convergence order, event-root accuracy, analytic gyration and energy conservation tests; drop tests of private helper internals.
Compiling the unrolled Dopri8 stages for the real VMEC equilibrium in the CPU reference test needed 15.5 GB and 91 s with jax 0.6.2 on x86. A single traced stage body returns it to 3.4 GB and 29 s, as before the simplification. The default remains the unrolled stages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the native orbit tracer on #187 while preserving the public tracing interface. Shared-host CPU timings were inconclusive.
The JAX 0.12 suite passed 408 tests, with one skip and one expected failure. Local CPU timings varied about 20% between runs. The native Boozer guiding-centre case had a 1.4e-14 error on both revisions.
Measurements and test conditions