Repository navigation
Simplify native split solver, tests and benchmarks - #197
Open
rogeriojorge wants to merge 11 commits into
Open
rogeriojorge wants to merge 11 commits into
rogeriojorge wants to merge 11 commits into
Conversation
Remove the experimental split controllers and options that are not part of the default path: full-step/two-half-step combined control, shared clock, the paper and candidate Wiener look-ahead controllers (with the collision error model and cumulative Brownian sampling they needed), the dense moment-defect reference (now an independent oracle in the tests) and unused flags. solve_split keeps one conservative collision controller; trace_split keeps "moments" and "conservative". CollisionStep and SplitStats lose their experimental fields. Add interpret=True to trace_split so the persistent GPU kernel can be run through the Pallas interpreter on CPU, and fix CSE in the scalar lowering so a duplicate of an equation with a dropped result no longer reads a dropped variable (this broke the adaptive kernel on jax 0.6.2). Tests: collision maps are checked against the Fokker-Planck generator (Lorentz pitch-angle moments, speed drift/diffusion, Maxwellian stationarity, Einstein relation), the Brownian bridge against its conditional law, Lie splitting against its exact first-order weak and strong error, and the independent GPU kernel against shared execution on coil, VMEC and Boozer fields.
Fold the one-function helper scripts into their callers (helix/mirror fields into the coordinate benchmark, spatial and combined references into the Lorentz and mirror references, event and conditional-noise helpers into the validators), drop the paired-convergence script that rewrote solver source at run time, and adapt the remaining scripts to the simplified solver API. Replace the two long result reports with one record of the validated numbers, caveats and timings, keep five figures, and shorten the README section to what users need.
…to simplify/native-split
…to simplify/native-split
…pts; add Spitzer, Ito/Stratonovich, absent-bath and low-energy tests
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the split solver PR, base
feat/native_split_collisions.What
essos/split.py, 2316 lines vs 2838): one conservative collision controller, no paper/candidate Wiener look-ahead or combined stepping;trace_split(..., interpret=True)runs the GPU kernel on CPU for tests; scalar-lowering CSE alias fix.benchmark_split_orbits.pystays as the timing script. Addsexamples/particle_tracing_collisions/native_split_slowing_down.py.<E> = 3T/2 + (E0 - 3T/2) exp(-2t/tau_s), 4%), Ito/Stratonovich consistency of the Milstein speed map (1e-5 rms against a Heun scheme, wrong drift off by 3e-2), absent bath (density 0), particle lost mid-step, float64. The speed updatev = sqrt(v1^2 + 4 D_par h)and the Lorentz l=1,2 eigenvalue test are kept.Checks
tests/test_native_split.py26 passed (9 min under load 200).