Skip to content

PEP 8 names: ElectricFieldFlux, ElectricFieldZero, species_indices, alm_model_lbfgs - #232

Open
rogeriojorge wants to merge 10 commits into
api-uniform-renamesfrom
api-pep8-names
Open

rogeriojorge wants to merge 10 commits into
api-uniform-renamesfrom
api-pep8-names

Conversation

@rogeriojorge

@rogeriojorge rogeriojorge commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Rename public symbols to PEP 8 forms and remove compatibility aliases. This breaks old callers. The migration table is in the README.

Measurements and test conditions

@eduardolneto eduardolneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged

eduardolneto and others added 4 commits November 13, 2026 16:47
Keep the PEP 8 names in the files both branches touch, use dofs instead of the x property of coils and surfaces, fix bdotn_over_b locals that shadowed the function, and drop the xfailed test of the old optimizer loss API.
@rogeriojorge
rogeriojorge changed the base branch from main to api-uniform-renames November 14, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants