Repository navigation
PEP 8 names: ElectricFieldFlux, ElectricFieldZero, species_indices, alm_model_lbfgs - #232
Open
rogeriojorge wants to merge 10 commits into
Open
rogeriojorge wants to merge 10 commits into
rogeriojorge wants to merge 10 commits into
Conversation
…s, alm_model_lbfgs
… properties and the legacy coil JSON format
Keep the PEP 8 names in the files both branches touch, use dofs instead of the x property of coils and surfaces, fix bdotn_over_b locals that shadowed the function, and drop the xfailed test of the old optimizer loss API.
…_order, ode_term; merge condition into stopping_criteria
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename public symbols to PEP 8 forms and remove compatibility aliases. This breaks old callers. The migration table is in the README.
Measurements and test conditions